[Jds-team] [OpenIndiana Distribution - Bug #1013] time-slider fails to take snapshots on complex dataset/snapshot configuration

[illumos project]

Issue #1013 has been updated by Chris Anders.


Im sorry but this wasn't tested :(

your change broke recursive and made its way into solaris 11 release... 

for me i have a zpool layout of:

tank1                                                                 com.sun:auto-snapshot  true                   local
tank1/installkits                                                     com.sun:auto-snapshot  true                   inherited from tank1
tank1/profadel                                                        com.sun:auto-snapshot  true                   inherited from tank1
tank1/profadel/fs1                                                    com.sun:auto-snapshot  true                   inherited from tank1
tank1/profadel/fs1/admin_only                                         com.sun:auto-snapshot  true                   inherited from tank1
tank1/profadel/fs1/common                                             com.sun:auto-snapshot  true                   inherited from tank1
tank1/profadel/fs1/profiles                                           com.sun:auto-snapshot  true                   inherited from tank1
tank1/profadel/fs1/programs                                           com.sun:auto-snapshot  true                   inherited from tank1
tank1/profadel/fs1/users                                              com.sun:auto-snapshot  true                   inherited from tank1
tank1/tmp                                                             com.sun:auto-snapshot  true                   inherited from tank1
tank1/vmware1                                                         com.sun:auto-snapshot  true                   inherited from tank1
tank1/vmware2                                                         com.sun:auto-snapshot  true                   inherited from tank1
tank1/vmware3                                                         com.sun:auto-snapshot  true                   inherited from tank1

With your change the time-slider executes the following:

ZFS CMD: ['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'tank1/prof/fs1/users at zfs-auto-snap_hourly-2011-11-12-23h16']
ZFS CMD: ['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'tank1/prof/fs1/programs at zfs-auto-snap_hourly-2011-11-12-23h16']
ZFS CMD: ['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'tank1/profl/fs1/profiles at zfs-auto-snap_hourly-2011-11-12-23h16']
ZFS CMD: ['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'tank1/profl/fs1/common at zfs-auto-snap_hourly-2011-11-12-23h16']
ZFS CMD: ['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'tank1/prof/fs1/admin_only at zfs-auto-snap_hourly-2011-11-12-23h16']
ZFS CMD: ['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'tank1/profl/fs1 at zfs-auto-snap_hourly-2011-11-12-23h16']
ZFS CMD: ['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'tank1 at zfs-auto-snap_hourly-2011-11-12-23h16']

2 problems with this.

1) its trying to run snapshot -r for each dataset instead of at the tank1 parent - the order / logic is now wrong
2) with the above list i get snapshots for:
tank1/prof/fs1/admin_only
tank1/prof/fs1/common
tank1/prof/fs1/profiles
tank1/prof/fs1/programs
tank1/prof/fs1/users
and nothing else.

time-slider tries to run zfs snapshot -r tank1/profl/fs1 at zfs-auto-snap_hourly-2011-11-12-23h16 but zfs reports:
cannot create snapshot 'tank1/prof/fs1/admin_only at zfs-auto-snap_hourly-2011-11-12-23h16' : dataset already exists
no snapshots were created

long story short after digging through the code i changed the line back to:
recursive.insert(0, datasetname)

and now when time-slider goes to snapshot the only cmd it executes is:
ZFS CMD: ['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'tank1 at zfs-auto-snap_frequent-2011-11-13-00h30']

looks like the logic of how the lists
        everything = []
        included = []
        excluded = []
        single = []
        recursive = []
        finalrecursive = []
are populated needs to re-thought out... 



----------------------------------------
Bug #1013: time-slider fails to take snapshots on complex dataset/snapshot configuration
https://www.illumos.org/issues/1013

Author: Florian Manschwetus
Status: Resolved
Priority: Normal
Assignee: OI JDS
Category: Desktop (JDS)
Target version: oi_151_stable
Difficulty: Medium
Tags: time-slider


pool-strukture:
data (freq,hourly,daily,weekly,monthly)
data/Admin (inherit)
data/Projects (inherit)
data/PublicWWW (inherit)
data/Teaching (inherit)
data/backup (inherit, -frequent)
data/backup/images (-all, +stagingdisk-schedule)
data/backup/images/linux (inherit)
data/backup/images/windows (inherit)
data/backup/serviceDaten (inherit)
data/backup/serviceDaten/linux (inherit)
data/backup/serviceDaten/windows (inherit)
data/cvs (no snaps, -all)
data/inc (no snaps, -all)
data/scratch (no snaps, -all)
data/test (no snaps, -all)
data/users (inherit)

Problem occurred when setting e.g. com.sun:auto-snapshot:hourly from false to inherit or true (com.sun:auto-snapshot is false on data, due to explicit schedule selection)

log snippet:

Failed to create snapshots for schedule: hourly
Caught RuntimeError exception in snapshot manager thread
Error details:
--------BEGIN ERROR MESSAGE--------
['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'data/backup/serviceDaten at zfs-auto-snap_hourly-2011-05-05-09h13'] failed with exit code 1
cannot create snapshot 'data/backup/serviceDaten/windows at zfs-auto-snap_hourly-2011-05-05-09h13': dataset already exists
no snapshots were created

--------END ERROR MESSAGE--------
Snapshot monitor thread exited.
[ Mai  5 09:13:06 Stopping because all processes in service exited. ]


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://www.illumos.org/my/account