[Jds-team] [OpenIndiana Distribution - Bug #1013] time-slider fails to take snapshots on complex dataset/snapshot configuration

[illumos project]

Issue #1013 has been updated by Johan Postema.


jpkoopmann reported an issue which is similar to the issue above:

Issue:
zfs property "com.sun:auto-snapshot(:*)=false" is ignored, causing time-slider to snapshot datasets/volumes that should be skipped instead.

Cause:
The piece of code that build the "single" and "recursive" lists fails to exclude these datasets because it assumes a sorted list.

Fix:
This could either be fixed to create a sorted "excluded" list, but in my opinion this is error prone an can lead easially to issues like these. I prefer to search the excluded list instead to figure out whether a dataset should be added to the single or to the recursive list.

Diff:

/usr/share/time-slider/lib/time_slider/zfs.py

<pre>
127c127,128
<                 if set(excluded).intersection([child]):
---
>                 idx = bisect_left(excluded, child)
>                 if idx < len(excluded) and excluded[idx] == child:
</pre>
----------------------------------------
Bug #1013: time-slider fails to take snapshots on complex dataset/snapshot configuration
https://www.illumos.org/issues/1013

Author: Florian Manschwetus
Status: Resolved
Priority: Normal
Assignee: OI JDS
Category: Desktop (JDS)
Target version: oi_151_stable
Difficulty: Medium
Tags: time-slider


pool-strukture:
data (freq,hourly,daily,weekly,monthly)
data/Admin (inherit)
data/Projects (inherit)
data/PublicWWW (inherit)
data/Teaching (inherit)
data/backup (inherit, -frequent)
data/backup/images (-all, +stagingdisk-schedule)
data/backup/images/linux (inherit)
data/backup/images/windows (inherit)
data/backup/serviceDaten (inherit)
data/backup/serviceDaten/linux (inherit)
data/backup/serviceDaten/windows (inherit)
data/cvs (no snaps, -all)
data/inc (no snaps, -all)
data/scratch (no snaps, -all)
data/test (no snaps, -all)
data/users (inherit)

Problem occurred when setting e.g. com.sun:auto-snapshot:hourly from false to inherit or true (com.sun:auto-snapshot is false on data, due to explicit schedule selection)

log snippet:

Failed to create snapshots for schedule: hourly
Caught RuntimeError exception in snapshot manager thread
Error details:
--------BEGIN ERROR MESSAGE--------
['/usr/bin/pfexec', '/usr/sbin/zfs', 'snapshot', '-r', 'data/backup/serviceDaten at zfs-auto-snap_hourly-2011-05-05-09h13'] failed with exit code 1
cannot create snapshot 'data/backup/serviceDaten/windows at zfs-auto-snap_hourly-2011-05-05-09h13': dataset already exists
no snapshots were created

--------END ERROR MESSAGE--------
Snapshot monitor thread exited.
[ Mai  5 09:13:06 Stopping because all processes in service exited. ]


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://www.illumos.org/my/account