[oi-dev] oi-build review process
kgunders at teamcool.net
Fri Aug 5 23:11:49 UTC 2011
On Sat, 2011-08-06 at 00:42 +0200, Guido Berhoerster wrote:
> looking at the first review for oi-build I think it is suboptimal
> that changes put up for review are already committed, changes
> requested by reviewers can lead to a number of additional commits
> which show up in the master repo and make changes more difficult
> to follow, furthermore I would find it desirable to have
> Reviewed-by headers in the commit message documenting our review
> process. I'm not familiar with how Bitbucket works but off the
> top of my head I can think of a number of solutions, changes
> could be kept in MQ during review and then be turned into commits
> before integration, there is a histedit Mercurial extension,
> there is webrev and there may be further options.
> It would also be nice to define some minimum time period for
> which stuff is put up for review in order to give interested
> parties enough time to look at changes.
> Any thoughts/opinions on this?
Seems reasonable to me. That this is not already happening is somewhat
of a strange release engineering model, no?
Regards-- Ken Gunderson
More information about the oi-dev