[oi-dev] review: gcc as primary compiler
buffer.g.overflow at gmail.com
Mon Feb 13 11:19:59 UTC 2012
What we've been talking about elsewhere is requiring people to have a
direct fork of the main development repo for each issue. You're asking us
to review changes against dilos-userland, which is itself a fork of
dilus-userland-review, which is private. If you want to have dilos-userland
as a playground, that's fine, but if it isn't forked in a way that allows
direct comparison on bitbucket (e.g. directly off the code base to which
you want to commit), you're asking reviewers to accept something other than
just what they can readily see. I find that runs contrary to the premise of
seeking reviews in the first place.
I don't see a compelling rationale for the more complicated arrangement
you're created, and you don't see to be offering one.
On Mon, Feb 13, 2012 at 10:52 AM, Igor Kozhukhov <ikozhukhov at gmail.com>wrote:
> At this moment illumos-userland - it is fork of dilos-userland - changes
> will be updated correctly.
> dilos-userland - it is public repo, not a private.
> From: Bayard Bell <buffer.g.overflow at gmail.com>
> Reply-To: OpenIndiana Developer mailing list <oi-dev at openindiana.org>
> Date: Mon, 13 Feb 2012 10:42:43 +0000
> To: OpenIndiana Developer mailing list <oi-dev at openindiana.org>
> Subject: Re: [oi-dev] review: gcc as primary compiler
> As this is also a policy issue, let's finalize this at #oi-meeting.
> Also, could we please submit changes to userland via forks of the public
> illumos-userland or oi-build (with the roll-out of illumos-userland under
> discussion at the next #oi-meeting, one item should be working off it alone
> going forward)? Using a fork of a private repo that may or may not diverge
> substantially from what everyone else is using makes it harder for people
> to evaluate.
> On Mon, Feb 13, 2012 at 10:30 AM, Igor Kozhukhov <ikozhukhov at gmail.com>wrote:
>> Hello All,
>> Please review:
>> It is big changeset with changes for "setup GCC as default compiler"
>> Best regards,
>> Igor Kozhukhov
>> IRC# igork
>> oi-dev mailing list
>> oi-dev at openindiana.org
> _______________________________________________ oi-dev mailing list
> oi-dev at openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
> oi-dev mailing list
> oi-dev at openindiana.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the oi-dev