Revisions now available at:<br><br><a href="https://bitbucket.org/buffyg/oi-build-1649/compare/..buffyg/oi-build">https://bitbucket.org/buffyg/oi-build-1649/compare/..buffyg/oi-build</a><br><br><div class="gmail_quote">On Sun, Feb 12, 2012 at 8:39 PM, Bayard Bell <span dir="ltr"><<a href="mailto:buffer.g.overflow@gmail.com">buffer.g.overflow@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im">On Sat, Feb 11, 2012 at 2:54 PM, Josef 'Jeff' Sipek <span dir="ltr"><<a href="mailto:jeffpc@josefsipek.net" target="_blank">jeffpc@josefsipek.net</a>></span> wrote:<br>
</div><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
On Fri, Feb 10, 2012 at 11:11:34PM +0000, Bayard Bell wrote:<br>
> <a href="https://www.illumos.org/issues/1649" target="_blank">https://www.illumos.org/issues/1649</a><br>
><br>
> <a href="https://bitbucket.org/buffyg/oi-build/changeset/36d948ceb5c3" target="_blank">https://bitbucket.org/buffyg/oi-build/changeset/36d948ceb5c3</a><br>
<br>
- OSOL vs. Illumos CDDL header<br></blockquote></div><div><br>I blame sample-manifest. I'll fix this and see if I can fix which license is populated into the sample manifest, too.<br> </div><div class="im"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">


- why are you using WS_TOP instead of '../..' that other components are<br>
  using?<br></blockquote></div><div><br>Not all components do this, particularly those located further down in the tree, which is where I learned this trick. WS_TOP is always valid, relative paths must vary by directory level, which is why I only use it with the shared-macros include, which defines WS_TOP in a way that's always valid for subsequent includes.<br>

 </div><div class="im"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
- why all the commented out lines?<br></blockquote></div><div><br>Copying, combined with the fact that the Makefile makes itself a dependency and thus re-makes everything when it's updated, even if it's to comment out lines. I'll remove them.<br>

 </div><div class="im"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Jeff.<br>
<br>
> _______________________________________________<br>
> oi-dev mailing list<br>
> <a href="mailto:oi-dev@openindiana.org" target="_blank">oi-dev@openindiana.org</a><br>
> <a href="http://openindiana.org/mailman/listinfo/oi-dev" target="_blank">http://openindiana.org/mailman/listinfo/oi-dev</a><br>
<span><font color="#888888"><br>
<br>
--<br>
I abhor a system designed for the "user", if that word is a coded pejorative<br>
meaning "stupid and unsophisticated."<br>
                - Ken Thompson<br>
<br>
_______________________________________________<br>
oi-dev mailing list<br>
<a href="mailto:oi-dev@openindiana.org" target="_blank">oi-dev@openindiana.org</a><br>
<a href="http://openindiana.org/mailman/listinfo/oi-dev" target="_blank">http://openindiana.org/mailman/listinfo/oi-dev</a><br>
</font></span></blockquote></div></div><br>
</blockquote></div><br>