What we've been talking about elsewhere is requiring people to have a direct fork of the main development repo for each issue. You're asking us to review changes against dilos-userland, which is itself a fork of dilus-userland-review, which is private. If you want to have dilos-userland as a playground, that's fine, but if it isn't forked in a way that allows direct comparison on bitbucket (e.g. directly off the code base to which you want to commit), you're asking reviewers to accept something other than just what they can readily see. I find that runs contrary to the premise of seeking reviews in the first place.<br>
<br>I don't see a compelling rationale for the more complicated arrangement you're created, and you don't see to be offering one.<br><br>On Mon, Feb 13, 2012 at 10:52 AM, Igor Kozhukhov <span dir="ltr"><<a href="mailto:ikozhukhov@gmail.com">ikozhukhov@gmail.com</a>></span> wrote:<br>
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word">
<div>At this moment illumos-userland - it is fork of dilos-userland - changes will be updated correctly.</div><div><br></div><div>dilos-userland - it is public repo, not a private.</div><div><br></div><div>-Igor</div><div>
<br></div><span><div style="padding:3pt 0in 0in;text-align:left;font-size:11pt;border-width:1pt medium medium;border-style:solid none none;border-color:rgb(181,196,223) -moz-use-text-color -moz-use-text-color;font-family:Calibri">
<span style="font-weight:bold">From: </span> Bayard Bell <<a href="mailto:buffer.g.overflow@gmail.com" target="_blank">buffer.g.overflow@gmail.com</a>><br><span style="font-weight:bold">Reply-To: </span> OpenIndiana Developer mailing list <<a href="mailto:oi-dev@openindiana.org" target="_blank">oi-dev@openindiana.org</a>><br>
<span style="font-weight:bold">Date: </span> Mon, 13 Feb 2012 10:42:43 +0000<br><span style="font-weight:bold">To: </span> OpenIndiana Developer mailing list <<a href="mailto:oi-dev@openindiana.org" target="_blank">oi-dev@openindiana.org</a>><br>
<span style="font-weight:bold">Subject: </span> Re: [oi-dev] review: gcc as primary compiler<br></div><div><div class="h5"><div><br></div><blockquote style>As this is also a policy issue, let's finalize this at #oi-meeting.<br>
<br>Also, could we please submit changes to userland via forks of the public illumos-userland or oi-build (with the roll-out of illumos-userland under discussion at the next #oi-meeting, one item should be working off it alone going forward)? Using a fork of a private repo that may or may not diverge substantially from what everyone else is using makes it harder for people to evaluate.<br>
<br><div class="gmail_quote">On Mon, Feb 13, 2012 at 10:30 AM, Igor Kozhukhov <span dir="ltr"><<a href="mailto:ikozhukhov@gmail.com" target="_blank">ikozhukhov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div style="word-wrap:break-word"><span style="font-size:14px;font-family:Calibri,sans-serif"><blockquote><div><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word"><div><div><div><br>Hello All,</div>
<div><br></div><div>Please review:</div><div><a href="https://bitbucket.org/dilos/dilos-userland/changeset/5e3079f6ad40" target="_blank">https://bitbucket.org/dilos/dilos-userland/changeset/5e3079f6ad40</a></div><div><br>
</div></div></div></div></div></blockquote></span><span style="font-size:14px;font-family:Calibri,sans-serif"><blockquote><div><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word"><div><div><div>
<a href="https://www.illumos.org/issues/2113" target="_blank">https://www.illumos.org/issues/2113</a></div></div></div></div></div></blockquote></span><span style="font-size:14px;font-family:Calibri,sans-serif"><blockquote>
<div><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word"><div><div><div>It is big changeset with changes for "<span style="color:rgb(57,57,57);font-size:12px;line-height:18px;white-space:pre-wrap;font-family:'Bitstream Vera Sans Mono','DejaVu Sans Mono',Monaco,monospace">setup GCC as default compiler</span>"</div>
</div></div></div></div></blockquote></span><span><blockquote style="border-left:5px solid rgb(181,196,223);padding:0px 0px 0px 5px;margin:0px 0px 0px 5px"><div><div style="word-wrap:break-word"><div><div><div><div><br></div>
<font style="font-family:Calibri,sans-serif;font-size:14px" face="Calibri,Verdana,Helvetica,Arial"><span style="font-size:11pt">---<br>
Best regards,<br>
Igor Kozhukhov</span></font></div></div></div></div></div></blockquote></span><span style="font-family:Calibri,sans-serif;font-size:14px"><blockquote><div><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word">
<div><div><div><font face="Calibri,Verdana,Helvetica,Arial"><span style="font-size:11pt">IRC# igork<br></span></font></div></div></div></div></div></blockquote></span></div><br>_______________________________________________<br>
oi-dev mailing list<br><a href="mailto:oi-dev@openindiana.org" target="_blank">oi-dev@openindiana.org</a><br><a href="http://openindiana.org/mailman/listinfo/oi-dev" target="_blank">http://openindiana.org/mailman/listinfo/oi-dev</a><br>
<br></blockquote></div><br>
_______________________________________________
oi-dev mailing list
<a href="mailto:oi-dev@openindiana.org" target="_blank">oi-dev@openindiana.org</a>
<a href="http://openindiana.org/mailman/listinfo/oi-dev" target="_blank">http://openindiana.org/mailman/listinfo/oi-dev</a>
</blockquote></div></div></span></div>
<br>_______________________________________________<br>
oi-dev mailing list<br>
<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a><br>
<a href="http://openindiana.org/mailman/listinfo/oi-dev" target="_blank">http://openindiana.org/mailman/listinfo/oi-dev</a><br>
<br></blockquote></div><br>