<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; "><div>About GNU_ARCH - it is not for this review and not changed.</div><div>It is value is using for GCC builds.</div><div>This review about changes to GCC as primary compiler.</div><div>About copyright - they are no changes in copyright on this change set.</div><div>I'll update copyright info for next components.</div><div><br></div><div>It is big chanegset and can we applied to illumos-userland, if all will agree.</div><div><br></div><div>-Igor</div><div><br></div><span id="OLK_SRC_BODY_SECTION"><div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt"><span style="font-weight:bold">From: </span> Andrew Stormont <<a href="mailto:andyjstormont@gmail.com">andyjstormont@gmail.com</a>><br><span style="font-weight:bold">Reply-To: </span> OpenIndiana Developer mailing list <<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a>><br><span style="font-weight:bold">Date: </span> Mon, 13 Feb 2012 11:24:13 +0000<br><span style="font-weight:bold">To: </span> OpenIndiana Developer mailing list <<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a>><br><span style="font-weight:bold">Subject: </span> Re: [oi-dev] review: gcc as primary compiler<br></div><div><br></div><blockquote id="MAC_OUTLOOK_ATTRIBUTION_BLOCKQUOTE" style="BORDER-LEFT: #b5c4df 5 solid; PADDING:0 0 0 5; MARGIN:0 0 0 5;"><div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; "><div>Hi Igor,</div><div><br></div><div>I've only had a quick scan through the changes but I'd say on the whole they look to be an improvement over what we currently have. However, there are two things I think you need to look at: 1) You still have some things that are copyright yourself 2) You do not seem to set GNU_ARCH but you are passing it in PKG_MACROS for at least one package.</div><div><br></div><div>Thanks,</div><div>Andrew</div><div><br></div><span id="OLK_SRC_BODY_SECTION"><div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt"><span style="font-weight:bold">From: </span> Igor Kozhukhov <<a href="mailto:ikozhukhov@gmail.com">ikozhukhov@gmail.com</a>><br><span style="font-weight:bold">Reply-To: </span> OpenIndiana Developer mailing list <<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a>><br><span style="font-weight:bold">Date: </span> Mon, 13 Feb 2012 14:52:55 +0400<br><span style="font-weight:bold">To: </span> OpenIndiana Developer mailing list <<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a>><br><span style="font-weight:bold">Subject: </span> Re: [oi-dev] review: gcc as primary compiler<br></div><div><br></div><div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; "><div>At this moment illumos-userland - it is fork of dilos-userland - changes will be updated correctly.</div><div><br></div><div>dilos-userland - it is public repo, not a private.</div><div><br></div><div>-Igor</div><div><br></div><span id="OLK_SRC_BODY_SECTION"><div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt"><span style="font-weight:bold">From: </span> Bayard Bell <<a href="mailto:buffer.g.overflow@gmail.com">buffer.g.overflow@gmail.com</a>><br><span style="font-weight:bold">Reply-To: </span> OpenIndiana Developer mailing list <<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a>><br><span style="font-weight:bold">Date: </span> Mon, 13 Feb 2012 10:42:43 +0000<br><span style="font-weight:bold">To: </span> OpenIndiana Developer mailing list <<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a>><br><span style="font-weight:bold">Subject: </span> Re: [oi-dev] review: gcc as primary compiler<br></div><div><br></div><blockquote id="MAC_OUTLOOK_ATTRIBUTION_BLOCKQUOTE" style="BORDER-LEFT: #b5c4df 5 solid; PADDING:0 0 0 5; MARGIN:0 0 0 5;">As this is also a policy issue, let's finalize this at #oi-meeting.<br><br>Also, could we please submit changes to userland via forks of the public illumos-userland or oi-build (with the roll-out of illumos-userland under discussion at the next #oi-meeting, one item should be working off it alone going forward)? Using a fork of a private repo that may or may not diverge substantially from what everyone else is using makes it harder for people to evaluate.<br><br><div class="gmail_quote">On Mon, Feb 13, 2012 at 10:30 AM, Igor Kozhukhov <span dir="ltr"><<a href="mailto:ikozhukhov@gmail.com">ikozhukhov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><span style="font-size: 14px; font-family: Calibri, sans-serif; "><blockquote style=""><div><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word"><div><div><div><br>Hello All,</div><div><br></div><div>Please review:</div><div><a href="https://bitbucket.org/dilos/dilos-userland/changeset/5e3079f6ad40" target="_blank">https://bitbucket.org/dilos/dilos-userland/changeset/5e3079f6ad40</a></div><div><br></div></div></div></div></div></blockquote></span><span style="font-size: 14px; font-family: Calibri, sans-serif; "><blockquote style=""><div><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word"><div><div><div><a href="https://www.illumos.org/issues/2113" target="_blank">https://www.illumos.org/issues/2113</a></div></div></div></div></div></blockquote></span><span style="font-size: 14px; font-family: Calibri, sans-serif; "><blockquote style=""><div><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word"><div><div><div>It is big changeset with changes for "<span style="color: rgb(57, 57, 57); font-size: 12px; line-height: 18px; white-space: pre-wrap; font-family: 'Bitstream Vera Sans Mono', 'DejaVu Sans Mono', Monaco, monospace; ">setup GCC as default compiler</span>"</div></div></div></div></div></blockquote></span><span><blockquote style="border-left:5px solid rgb(181,196,223);padding:0px 0px 0px 5px;margin:0px 0px 0px 5px"><div><div style="word-wrap:break-word"><div><div><div><div><br></div><font style="font-family:Calibri,sans-serif;font-size:14px" face="Calibri,Verdana,Helvetica,Arial"><span style="font-size:11pt">---<br>
Best regards,<br>
Igor Kozhukhov</span></font></div></div></div></div></div></blockquote></span><span style="font-family:Calibri,sans-serif;font-size:14px"><blockquote style=""><div><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word"><div><div><div><font face="Calibri,Verdana,Helvetica,Arial"><span style="font-size:11pt">IRC# igork<br></span></font></div></div></div></div></div></blockquote></span></div><br>_______________________________________________<br>
oi-dev mailing list<br><a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a><br><a href="http://openindiana.org/mailman/listinfo/oi-dev" target="_blank">http://openindiana.org/mailman/listinfo/oi-dev</a><br><br></blockquote></div><br>
_______________________________________________
oi-dev mailing list
<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a><a href="http://openindiana.org/mailman/listinfo/oi-dev">http://openindiana.org/mailman/listinfo/oi-dev</a></blockquote></span></div></div>
_______________________________________________
oi-dev mailing list
<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a><a href="http://openindiana.org/mailman/listinfo/oi-dev">http://openindiana.org/mailman/listinfo/oi-dev</a></span></div></div>
_______________________________________________
oi-dev mailing list
<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a>
<a href="http://openindiana.org/mailman/listinfo/oi-dev">http://openindiana.org/mailman/listinfo/oi-dev</a>
</blockquote></span></body></html>