<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">HI Marcel,<div><br></div><div>Thanks for review. I updated the changeset.</div><div><br><div><br></div><div><br></div><div><br></div><div><blockquote type="cite"><br>m4:<br><br>- minor nit: why a change at line 41 in the Makefile?<br> 1.26 -CONFIGURE_PREFIX =<span class="Apple-tab-span" style="white-space:pre"> </span>/usr/gnu<br> 1.27 +CONFIGURE_PREFIX =<span class="Apple-tab-span" style="white-space:pre"> </span>/usr/gnu<br>- Some copyright related note removal in m4.license (see the MyGCN above)<br>- Oracle copyright removed from m4.p5m (see the MyGCN above)<br>- pkg.description removed from m4.p5m. why?<br>- opensolaris.arc_url removed from m4.p5m. intentional? why?<br>- otherwise: LGTM<br></blockquote><div><a href="https://hg.openindiana.org/users/xenol/oi-build/rev/a62dd54980b1">https://hg.openindiana.org/users/xenol/oi-build/rev/a62dd54980b1</a></div><div><br></div><div>opensolaris.arc_url was removed because sample-manifest does not generate one and from my understanding it is used for Oracle's internal use. If I am wrong, can somebody tell me what it is used for? </div><br><blockquote type="cite">automake:<br><br>- shouldn't the automake-1.13/automake.p5m go to a separate directory?<br> something like automake/automake.p5m. With the current implementation<br> once we will integrate version 1.14 we will need to move this file<br> to a new location<br>- otherwise LGTM<br></blockquote><div><br></div><div><a href="https://hg.openindiana.org/users/xenol/oi-build/rev/c7c3eed4d97b">https://hg.openindiana.org/users/xenol/oi-build/rev/c7c3eed4d97b</a></div><div><br></div>I will create meta-packages/automake in the near future alongside with other packages. For now, I am leaving it as is. <br><br><div><br></div><blockquote type="cite">autoconf:<br><br>- Basically LGTM<br>- Oracle copyright removed from autoconf.p5m (see the MyGCN above)<br>- is opensolaris.arc_url removal from autoconf.p5m intentional?<br></blockquote><br><a href="https://hg.openindiana.org/users/xenol/oi-build/rev/e8e84559f159">https://hg.openindiana.org/users/xenol/oi-build/rev/e8e84559f159</a></div><div><br><div>Nope, it wasn't removed intentionally. I regenerated p5m file with sample-manifest and it wasn't generated, so I didn't bother to add it there.</div><div><br></div><blockquote type="cite"><br>help2man:<br><br>- since there is no conflict with other Solaris/illumos/OI tools I'd<br> put this into /usr/bin/ (insteadd of /usr/gnu)<br>- otherwise: LGTM<br></blockquote><br></div></div><div><a href="https://hg.openindiana.org/users/xenol/oi-build/rev/3e7752f531e1">https://hg.openindiana.org/users/xenol/oi-build/rev/3e7752f531e1</a></div><div><br></div><div>I removed 'g' prefixed version of help2man. However, I left it in /usr/gnu as it is part of the gnu userland. </div><div><br></div><div>Once again, thank you for a review.</div><div><br></div><div>Cheers,</div><div><br></div><div>Adam</div></body></html>