<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><a href="https://github.com/xen0l/oi-userland/commit/f341a6af89af873790c5d1ac006dbd8ebca6ee5a">https://github.com/xen0l/oi-userland/commit/f341a6af89af873790c5d1ac006dbd8ebca6ee5a</a><div><br></div><div><div><div>On Aug 5, 2013, at 8:19 PM, Adam Števko <<a href="mailto:adam.stevko@gmail.com">adam.stevko@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I will add these shortly.<br><br>On Aug 5, 2013, at 7:50 PM, Alexander Pyhalov <<a href="mailto:alp@rsu.ru">alp@rsu.ru</a>> wrote:<br><br><blockquote type="cite">Hello, Adam.<br><br>Adam Števko писал 05.08.2013 19:50:<br><br><blockquote type="cite"><a href="https://github.com/xen0l/oi-userland/commit/6842d7ffb4ed409a276f9e06a8e5310ad7d5764f">https://github.com/xen0l/oi-userland/commit/6842d7ffb4ed409a276f9e06a8e5310ad7d5764f</a><br>- Alasdair's issue (https://www.illumos.org/issues/2682), which brings<br>in sane default for configuration environment. Many components already<br>sets these in their Makefile and I don't see reasons, why we shouldn't<br>make them default.<br>I commented out CONFIGURE_OPTIONS as I found them redundant. From my<br>understanding, configure will set these to environment variables, so<br>CONFIGURE_ENV should be sufficient. If there are any objections I will<br>restore CONFIGURE_OPTIONS.<br></blockquote><br>I don't think that this is redundant. Are you sure in this?<br>It seems I've seen cases when CONFIGURE_ENV was no enough<br>(whaen configure in its own turn called configure).<br>I would dublicate all CONFIGURE_ENV (CC,LD,CFLAGS,etc...) settings in CONFIGURE_OPTIONS.<br>Otherwise changes look reasonable.<br>---<br>System Administrator of Southern Federal University Computer Center<br><br><br><br>_______________________________________________<br>oi-dev mailing list<br><a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a><br>http://openindiana.org/mailman/listinfo/oi-dev<br></blockquote><br></blockquote></div><br></div></body></html>