<div dir="ltr"><div><div><div>Hi Alexander,<br></div>I removed the two added tabs, I had the bad reflex of aligning the variables in my editor without thinking, sorry.<br></div>It seems the pull request is still open on Github and the diff shows that it will take into account the removed tabs in the last commit <code><font><a href="https://github.com/alarcher/oi-userland/commit/bd9d92a73334c1685f752f6d837a1a66e1d38bee" target="_blank">bd9d92a</a></font><br>
</code></div><code><span style="font-family:arial,helvetica,sans-serif"></span></code><div><code><br><a href="https://github.com/alarcher/oi-userland/commit/bd9d92a73334c1685f752f6d837a1a66e1d38bee" target="_blank"></a></code><div class="gmail_extra">
Best regards,<br><br></div><div class="gmail_extra">Aurélien<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 19, 2013 at 5:32 AM, Alexander Pyhalov <span dir="ltr"><<a href="mailto:alp@rsu.ru" target="_blank">alp@rsu.ru</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello, Aurélien.<br>
<br>
Aurélien Larcher писал 18.11.2013 23:19:<div><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
I needed to edit <a href="http://shared-macros.mk" target="_blank">shared-macros.mk</a> to add variables for the FORTRAN<br>
compilers which I did in a branch 'add_fortran_macros'.<br>
The relevant commit is:<br>
<a href="https://github.com/alarcher/oi-userland/commit/dcd7bac1ba90e24adc5a25b38a5332de3fd54e86" target="_blank">https://github.com/alarcher/<u></u>oi-userland/commit/<u></u>dcd7bac1ba90e24adc5a25b38a5332<u></u>de3fd54e86</a><br>
</blockquote>
<br></div>
LGTM.<br>
However, could you avoid touching existing options? (There are unnecessary formatiing changes for CC.gcc.32 / CC.gcc.64).<br>
Please, correct this and recreate pull request. Thank you for working on OpenIndiana.<br>
---<br>
System Administrator of Southern Federal University Computer Center<br>
<br>
<br>
______________________________<u></u>_________________<br>
oi-dev mailing list<br>
<a href="mailto:oi-dev@openindiana.org" target="_blank">oi-dev@openindiana.org</a><br>
<a href="http://openindiana.org/mailman/listinfo/oi-dev" target="_blank">http://openindiana.org/<u></u>mailman/listinfo/oi-dev</a></blockquote></div><br><br clear="all"><br>-- <br><font style="font-family:courier new,monospace" size="1">-------------------------------------------------------------------------------<br>
LARCHER Aurélien | KTH, School of Computer Science and Communication<br>
Work: <a value="+4687907142">+46 (0) 8 790 71 42</a> | Lindstedtsvägen 5, Plan 5<br>Mob.: <a value="+46709464017">+46 (0) 7 09 46 40 17</a> | 100 44 Stockholm, SWEDEN<br>-------------------------------------------------------------------------------<br>
Praise the Caffeine embeddings ...</font>
</div></div></div>