<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hi,</div><br><div><div>On 26 Nov 2013, at 11:27, Alexander Pyhalov <<a href="mailto:alp@rsu.ru">alp@rsu.ru</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On 11/25/2013 22:42, Jim Klimov wrote:<br><blockquote type="cite">On 2013-11-25 16:27, Alexander Pyhalov wrote:<br><blockquote type="cite">Hello.<br><br>Please, review <a href="http://cr.illumos.org/~webrev/alp/3395/">http://cr.illumos.org/~webrev/alp/3395/</a><br></blockquote><br>Can't the Makefile blocks like this:<br><br>profile: etc-profile.sh<br> $(RM) profile<br> $(CP) etc-profile.sh $@<br><br>be remade into this:<br><br>profile: etc-profile.sh<br> $(RM) $@<br> $(CP) $< $@<br><br>This would simplify copy-pasting of standardized actions :)<br></blockquote><br>$(CP) $< $@ part doesn't work:<br><br>$ dmake clean install<br>/usr/bin/rm -f profile<br>/usr/bin/cp -f profile<br>cp: Insufficient arguments (1)<br>Usage: cp [-a] [-f] [-i] [-p] [-@] [-/] f1 f2<br> cp [-a] [-f] [-i] [-p] [-@] [-/] f1 ... fn d1<br> cp [-r|-R [-H|-L|-P]] [-a] [-f] [-i] [-p] [-@] [-/] d1 ... dn-1 dn<br>*** Error code 2<br><br></div></blockquote><div><br></div><div>You should almost certainly be using $(INS.file) instead here.</div><div>As somebody involved with distros I welcome these changes.</div><div><br></div><div>Andy.</div><br><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br><br>--<span class="Apple-converted-space"> </span><br>Best regards,<br>Alexander Pyhalov,<br>system administrator of Computer Center of Southern Federal University<br><br>_______________________________________________<br>oi-dev mailing list<br><a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a><br><a href="http://openindiana.org/mailman/listinfo/oi-dev">http://openindiana.org/mailman/listinfo/oi-dev</a></div></blockquote></div><br></body></html>