<html><body><div style="font-family: Verdana; font-size: 12pt; color: #000000"><div aria-label="Compose body">Matt, </div><div aria-label="Compose body"><br></div><div aria-label="Compose body">I'll check it out. And thanks for contributing!</div><div aria-label="Compose body"><br></div><div aria-label="Compose body">Lou Picciano</div><div><br></div><hr id="zwchr"><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Matt Samudio" <matt@samudio.net><br><b>To: </b>oi-dev@openindiana.org<br><b>Sent: </b>Tuesday, May 26, 2015 4:35:44 PM<br><b>Subject: </b>[oi-dev] Review for new package - abook<br><div><br></div>Hi all,<br><div><br></div>This is my first attempt at contributing, so I selected something<br>fairly easy - introducing a new package for a simple piece of<br>software called "abook", which is a console-based program for<br>address books, used frequently with the mutt email client.<br><div><br></div>Would someone like to review what I've done, to make sure its<br>ready for me to make a pull request ?<br><div><br></div>My github login is rk4n3, and I checked my work into my fork<br>of hipster oi-userland on a branch named "rk4n3dev_abook".<br><div><br></div>I tested my work by performing the build in a build zone, publishing<br>the package to a publisher running in my build zone, installing<br>in a clean test zone by pointing the test zone at the build zone's<br>publisher, and running the program from a normal (non-root) login,<br>trying basic functionality that I know about from using the<br>program. There is no test suite delivered with the software.<br><div><br></div>Please advise me if I've made any mistakes, or not completed<br>everything I should ...<br><div><br></div>Thanks,<br>Matt Samudio<br><div><br></div><br>_______________________________________________<br>oi-dev mailing list<br>oi-dev@openindiana.org<br>http://openindiana.org/mailman/listinfo/oi-dev<br></div><div><br></div></div></body></html>