<div dir="ltr">Thanks for the info I just sent the web rev to the mailing list we ll see. Regards.</div><div class="gmail_extra"><br><div class="gmail_quote">On 8 May 2017 at 18:04, Aurélien Larcher <span dir="ltr"><<a href="mailto:aurelien.larcher@gmail.com" target="_blank">aurelien.larcher@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="m_862595358340615178gmail-m_-5026023351823752802gmail-"></span>Hi,<br><br><div class="gmail_extra"><div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Since your fix is related to illumos-gate I suggest to read </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<a href="https://wiki.illumos.org/display/illumos/How+To+Contribute" rel="noreferrer" target="_blank">https://wiki.illumos.org/displ<wbr>ay/illumos/How+To+Contribute</a><br>
<a href="http://illumos.org/books/dev/" rel="noreferrer" target="_blank">http://illumos.org/books/dev/</a><br>
<br>
to get more info about contributing to illumos.<br></blockquote><div><br></div></span><div>I submitted my first request to integrate very recently and I can confirm that the steps described on the Wiki cover pretty much everything.<br></div><div><br>To summarize the steps:<br></div><div><br></div><div>1) Publish a webrev with your changes using the webrev or the review board [1].<br><br></div><div>2) Ask for review by sending an email to the illumos developer mailing list [2], describing the change and how it was tested.<br><br></div><div>3) When you have at least two reviewers validating the change, send an email to the advocates mailing list [3]<br><br></div><div>The email to be sent for RTI has no strict format, so I looked at previous message in the archives, like the following:<br><br><a href="https://illumos.topicbox.com/groups/advocates/discussions/Tdf240fa5ca857b39" target="_blank">https://illumos.topicbox.com/<wbr>groups/advocates/discussions/<wbr>Tdf240fa5ca857b39</a><br></div><br>as described in "5. Submitting A Patch": `git whatchanged`, `git pbchk`, and the mail_msg file should be provided.<br><br></div><div class="gmail_quote">The only thing that could be clarified is that the review board seems the preferred way to ask for review but its usage is not described much.<br><br></div><div class="gmail_quote">Nice that you fixed the memory leak, I noticed it when I tested the Valgrind update to 3.12 but then forgot about it :S Thanks!<br></div><div class="gmail_quote">Kind regards<br><br></div><div class="gmail_quote">Aurelien</div><div class="gmail_quote"> <div><br><br>[1] <a href="https://www.illumos.org/rb" target="_blank">https://www.illumos.org/rb</a><br>[2] <a href="https://www.listbox.com/subscribe/?listname=developer@lists.illumos.org" target="_blank">https://www.listbox.com/subscr<wbr>ibe/?listname=developer@lists.<wbr>illumos.org</a><br>[3] advocates@<a href="http://lists.illumos.org" target="_blank">lists.illumos.org</a><br><br><br><br><br></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Thanks.<span class="m_862595358340615178gmail-m_-5026023351823752802gmail-HOEnZb"><font color="#888888"><br>
<br>
-- <br>
+-----------------------------<wbr>--------------+<br>
| Marcel Telka e-mail: <a href="mailto:marcel@telka.sk" target="_blank">marcel@telka.sk</a> |<br>
| homepage: <a href="http://telka.sk/" rel="noreferrer" target="_blank">http://telka.sk/</a> |<br>
| jabber: <a href="mailto:marcel@jabber.sk" target="_blank">marcel@jabber.sk</a> |<br>
+-----------------------------<wbr>--------------+<br>
<br>
<br>
______________________________<wbr>_________________<br>
oi-dev mailing list<br>
<a href="mailto:oi-dev@openindiana.org" target="_blank">oi-dev@openindiana.org</a><br>
<a href="https://openindiana.org/mailman/listinfo/oi-dev" rel="noreferrer" target="_blank">https://openindiana.org/mailma<wbr>n/listinfo/oi-dev</a></font></span></blockquote></span></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div class="m_862595358340615178gmail-m_-5026023351823752802gmail_signature"><div dir="ltr"><div><div dir="ltr"><font style="font-family:courier new,monospace" size="1">---<br>Praise the Caffeine embeddings<br></font></div></div></div></div>
</font></span></div></div>
<br>______________________________<wbr>_________________<br>
oi-dev mailing list<br>
<a href="mailto:oi-dev@openindiana.org">oi-dev@openindiana.org</a><br>
<a href="https://openindiana.org/mailman/listinfo/oi-dev" rel="noreferrer" target="_blank">https://openindiana.org/<wbr>mailman/listinfo/oi-dev</a><br></blockquote></div><br></div>