[oi-dev] oi-build review process

Guido Berhoerster gber at openindiana.org
Fri Aug 5 22:42:42 UTC 2011


Hello,

looking at the first review for oi-build I think it is suboptimal
that changes put up for review are already committed, changes
requested by reviewers can lead to a number of additional commits
which show up in the master repo and make changes more difficult
to follow, furthermore I would find it desirable to have
Reviewed-by headers in the commit message documenting our review
process. I'm not familiar with how Bitbucket works but off the
top of my head I can think of a number of solutions, changes
could be kept in MQ during review and then be turned into commits
before integration, there is a histedit Mercurial extension,
there is webrev and there may be further options.

It would also be nice to define some minimum time period for
which stuff is put up for review in order to give interested
parties enough time to look at changes.

Any thoughts/opinions on this?
-- 
Guido Berhoerster



More information about the oi-dev mailing list