[oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Josef 'Jeff' Sipek]

On Mon, Nov 07, 2011 at 04:52:51PM +0000, Colin Ellis wrote:
> bitbucket https://bitbucket.org/cellis_oidev/oi-build/changeset/3c3b8bb07540

I know nothing about ruby, but here are a few things I noticed...

- Oracle copyright/OSOL CDDL header.
- hardcoded "GMAKE=gmake -j16"
- GCC_ROOT hardcoded, is there an issue with gcc46?
- again, you are not Random Developer - check you p5m
- the .so have 'i386' hardcoded in the path (e.g.,
  path=usr/lib/$(MACH64)/ruby/1.9.1/i386-solaris2.11/enc/iso_8859_14.so)
- this is a lot of files; is this really one package? or should it be
  several?

Jeff.


> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev


-- 
What is the difference between Mechanical Engineers and Civil Engineers?
Mechanical Engineers build weapons, Civil Engineers build targets.