[oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Josef 'Jeff' Sipek]

On Sat, Nov 12, 2011 at 06:40:00PM +0000, Colin Ellis wrote:
> Fixes are here:
> 
> https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d
> 
> Not sure about hardcoded bit in the p5m file.  It got generated like that.
> 
> I believe this should be a single package but others might disagree.  I
> wouldn't know where to start to split it apart though!

I've never dealt with Ruby so I don't have any intuition about this. So,
LGTM.

Jeff.

> 
> 
> On Sat, Nov 12, 2011 at 3:42 AM, Josef 'Jeff' Sipek
> <jeffpc at josefsipek.net>wrote:
> 
> > On Mon, Nov 07, 2011 at 04:52:51PM +0000, Colin Ellis wrote:
> > > bitbucket
> > https://bitbucket.org/cellis_oidev/oi-build/changeset/3c3b8bb07540
> >
> > I know nothing about ruby, but here are a few things I noticed...
> >
> > - Oracle copyright/OSOL CDDL header.
> > - hardcoded "GMAKE=gmake -j16"
> > - GCC_ROOT hardcoded, is there an issue with gcc46?
> > - again, you are not Random Developer - check you p5m
> > - the .so have 'i386' hardcoded in the path (e.g.,
> >  path=usr/lib/$(MACH64)/ruby/1.9.1/i386-solaris2.11/enc/iso_8859_14.so)
> > - this is a lot of files; is this really one package? or should it be
> >  several?
> >
> > Jeff.
> >
> >
> > > _______________________________________________
> > > oi-dev mailing list
> > > oi-dev at openindiana.org
> > > http://openindiana.org/mailman/listinfo/oi-dev
> >
> >
> > --
> > What is the difference between Mechanical Engineers and Civil Engineers?
> > Mechanical Engineers build weapons, Civil Engineers build targets.
> >
> > _______________________________________________
> > oi-dev mailing list
> > oi-dev at openindiana.org
> > http://openindiana.org/mailman/listinfo/oi-dev
> >

> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev


-- 
I already backed up the [server] once, I can do it again.
		- a sysadmin threatening to do more frequent backups