[oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Alasdair Lumsden]

Hi Colin,

Great stuff! Only minor nitpicks:

On the Makefile, you've got multiple configure options per 
CONFIGURE_OPTION, and the indentation of the macros is a bit iffy. But 
if you like I can tidy these up when we commit, saving you the bother.

Did you have any luck finding out about the DTrace patches? Also did you 
give make test a go?

Cheers,

Alasdair

On 11/19/11 09:54 PM, Colin Ellis wrote:
> https://bitbucket.org/cellis_oidev/oi-build/changeset/4c13f4869651
>
> On Tue, Nov 15, 2011 at 9:32 AM, Guido Berhoerster <gber at openindiana.org
> <mailto:gber at openindiana.org>> wrote:
>
>     * Colin Ellis <panamayacht at gmail.com <mailto:panamayacht at gmail.com>>
>     [2011-11-12 19:40]:
>      > Fixes are here:
>      >
>      > https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d
>
>     Have you looked through the ruby 1.8 patches and checked which
>     are still applicable? At least the DTrace changes should probably
>     be ported over.
>     Have you checked the built ruby interpeter? Running "make test"
>     on the source tree after building should be an easy way to catch
>     any issues.
>     --
>     Guido Berhoerster
>
>     _______________________________________________
>     oi-dev mailing list
>     oi-dev at openindiana.org <mailto:oi-dev at openindiana.org>
>     http://openindiana.org/mailman/listinfo/oi-dev
>
>
>
>
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev