[oi-dev] 1686 Bring Xmedcon to oi build, Ask for review

[Josef 'Jeff' Sipek]

On Tue, Oct 25, 2011 at 06:41:50PM +0200, Paolo Marcheschi wrote:
> Hi
> 
> This is my first contribution I'm asking for a review,
> 
> Xmedcon  is a medical imaging software that helps for conversion of
> medical images expecially Brain MRI images.  I pushed to :
> 
> https://bitbucket.org/paolo_marcheschi/oi-build

Ok, here are my comments:

- don't commit the source & build directories (just the Makefile, the .p5m
  file, the license file (usually called $(FOO).license), and if you happen
  to have any patches then those too
- xmedconrc should be in /etc (not /usr/etc) if it is a global config file
- at some point, someone should open a feature request on the bug tracker
  (bugs.openindiana.org) - so that we can use the commit message format:
  "<bugnum> <description>"

Jeff.

-- 
mainframe, n.:
  An obsolete device still used by thousands of obsolete companies serving
  billions of obsolete customers and making huge obsolete profits for their
  obsolete shareholders. And this year's run twice as fast as last year's.