[oi-dev] [developer] Please review: 3395 add /etc/profile.d and /etc/.login.d

Alexander Pyhalov alp at rsu.ru
Tue Nov 26 11:27:31 UTC 2013


On 11/25/2013 22:42, Jim Klimov wrote:
> On 2013-11-25 16:27, Alexander Pyhalov wrote:
>> Hello.
>>
>> Please, review http://cr.illumos.org/~webrev/alp/3395/
>
> Can't the Makefile blocks like this:
>
> profile: etc-profile.sh
>          $(RM) profile
>          $(CP) etc-profile.sh $@
>
> be remade into this:
>
> profile: etc-profile.sh
>          $(RM) $@
>          $(CP) $< $@
>
> This would simplify copy-pasting of standardized actions :)

$(CP) $< $@ part doesn't work:

$ dmake clean install
/usr/bin/rm -f profile
/usr/bin/cp -f  profile
cp: Insufficient arguments (1)
Usage: cp [-a] [-f] [-i] [-p] [-@] [-/] f1 f2
        cp [-a] [-f] [-i] [-p] [-@] [-/] f1 ... fn d1
        cp [-r|-R [-H|-L|-P]] [-a] [-f] [-i] [-p] [-@] [-/] d1 ... dn-1 dn
*** Error code 2



-- 
Best regards,
Alexander Pyhalov,
system administrator of Computer Center of Southern Federal University




More information about the oi-dev mailing list