[oi-dev] Review switch of /usr/perl5/bin/perl to perl 5.16
Alexander Pyhalov
alp at rsu.ru
Mon Jun 16 16:57:54 UTC 2014
On 06/16/2014 17:26, Andy Stormont wrote:
>
> On 16 Jun 2014, at 14:10, Alexander Pyhalov <alp at rsu.ru> wrote:
>
>> On 06/16/2014 16:40, Andy Stormont wrote:
>>> I have a couple of nits to pick:
>>
>>
>> Yes, these are two 'rude hacks'.
>> .cleaned rule is necessary to force re-applying patch on update. So that we can see when patch is not applied after git pull. This also should help when patch file is changed. Without this target it would create garbage or failed to apply. It's because we don't do "real clean" (i.e. rm -fr $(SOURCE_DIR)) on clean target.
>>
>
> I would suggest collapsing the .%ed, .cleaned and .patched rules into one then.
>
Collapsed .%ed, .cleaned, .closed-binaries and .patched rules into one
rule. .closed-binaries depended on .downloaded, so it also had to be
merged into .patched.
--
Best regards,
Alexander Pyhalov,
system administrator of Computer Center of Southern Federal University
More information about the oi-dev
mailing list