[oi-dev] [OpenIndiana-discuss] Sun/Oracle China's DRM//KMS Sol11.2 port backported to function on old-style gfxp_private from pre-2010 era but still immediatedly PANICS

Мартин Бохниг opensxce at mail.ru
Sat Dec 12 11:10:30 UTC 2015


>agpgart doesn't care about the drm/i915 pci id's either.
>
>   The one that is relevant is the id's in the package manifest:
>
>https://hg.openindiana.org/upstream/oracle/x-cons/x-s12-clone/file/5dc3c751c9c5/pkg/manifests/driver-graphics-drm.p5m
>


That one is only the external bindings for attaching during add_drv of i915.



>And I'm guessing that the pciid for the X230 is in this list, as HD 4000 
>should work.
>
>> First let's give Sun/Oracle Menlo Park some time to respond.
>
>   Two comments immediately come to mind:
>
>    Don't be changing copyrights
>    Be mindful of attribution of imported source.
>
>
>
>rf
>_______________________________________________
>oi-dev mailing list
>oi-dev at openindiana.org
>http://openindiana.org/mailman/listinfo/oi-dev



Did I hear correctly??
You say: "agpgart doesn't care about the drm/i915 pci id's either." ??

At least here on my outdated in_progress hybrid (and I doubt this is different on Sol11.x), no gart, no luck:


 grep -n agpgart /etc/*
/etc/minor_perm:303:agpgart:* 0644 root sys
/etc/name_to_major:328:agpgart 282
/etc/path_to_inst:10:"/agpgart" 0 "agpgart"
/etc/path_to_inst.old:10:"/agpgart" 0 "agpgart"
martin at opensxce:/tmp/REALcosmicrescue/TMP/MAGIC/kernel# grep -n gart /etc/*
/etc/driver_aliases:1111:amd64_gart "pci1022,1103"
/etc/minor_perm:302:amd64_gart:* 0644 root sys
/etc/minor_perm:303:agpgart:* 0644 root sys
/etc/name_to_major:327:amd64_gart 281
/etc/name_to_major:328:agpgart 282
/etc/path_to_inst:10:"/agpgart" 0 "agpgart"
/etc/path_to_inst.old:10:"/agpgart" 0 "agpgart"
martin at opensxce:/tmp/REALcosmicrescue/TMP/MAGIC/kernel# grep -n agp /etc/*
/etc/driver_aliases:1071:agptarget "pci8086,7124"
/etc/driver_aliases:1072:agptarget "pci8086,7122"
/etc/driver_aliases:1073:agptarget "pci8086,7120"
/etc/driver_aliases:1074:agptarget "pci1022,7454"
/etc/driver_aliases:1075:agptarget "pci8086,3580"
/etc/driver_aliases:1076:agptarget "pci8086,3575"
/etc/driver_aliases:1077:agptarget "pci8086,2560"
/etc/driver_aliases:1078:agptarget "pci8086,2570"
/etc/driver_aliases:1079:agptarget "pci8086,2580"
/etc/driver_aliases:1080:agptarget "pci8086,2590"
/etc/driver_aliases:1081:agptarget "pci8086,2770"
/etc/driver_aliases:1082:agptarget "pci8086,27a0"
/etc/driver_aliases:1083:agptarget "pci8086,27ac"
/etc/driver_aliases:1084:agptarget "pci8086,2970"
/etc/driver_aliases:1085:agptarget "pci8086,2980"
/etc/driver_aliases:1086:agptarget "pci8086,2990"
/etc/driver_aliases:1087:agptarget "pci8086,29a0"
/etc/driver_aliases:1088:agptarget "pci8086,29b0"
/etc/driver_aliases:1089:agptarget "pci8086,29c0"
/etc/driver_aliases:1090:agptarget "pci8086,29d0"
/etc/driver_aliases:1091:agptarget "pci8086,2a00"
/etc/driver_aliases:1092:agptarget "pci8086,2a10"
/etc/driver_aliases:1093:agptarget "pci8086,2a40"
/etc/driver_aliases:1094:agptarget "pci8086,2e00"
/etc/driver_aliases:1095:agptarget "pci8086,2e10"
/etc/driver_aliases:1096:agptarget "pci8086,2e20"
/etc/driver_aliases:1097:agptarget "pci8086,2e30"
/etc/driver_aliases:1098:agptarget "pci8086,2e40"
/etc/driver_aliases:1099:agptarget "pci8086,40"
/etc/driver_aliases:1100:agptarget "pci8086,44"
/etc/driver_aliases:1101:agptarget "pci8086,62"
/etc/driver_aliases:1102:agptarget "pci8086,6a"
/etc/driver_aliases:1103:agptarget "pci8086,1130"
/etc/driver_aliases:1104:agptarget "pci8086,3340"
/etc/driver_aliases:1105:agptarget "pci8086,100"
/etc/driver_aliases:1106:agptarget "pci8086,104"
/etc/driver_aliases:1107:agptarget "pci8086,108"
/etc/driver_aliases:1108:agptarget "pci8086,150"
/etc/driver_aliases:1109:agptarget "pci8086,154"
/etc/driver_aliases:1110:agptarget "pci8086,158"
/etc/minor_perm:301:agptarget:* 0644 root sys
/etc/minor_perm:303:agpgart:* 0644 root sys
/etc/mnttab:1:rpool1/ROOT/agp   /       zfs     dev=2d90002     0
/etc/name_to_major:326:agptarget 280
/etc/name_to_major:328:agpgart 282
/etc/path_to_inst:10:"/agpgart" 0 "agpgart"
/etc/path_to_inst:62:"/pci at 0,0/pci8086,100 at 0" 0 "agptarget"
/etc/path_to_inst.old:10:"/agpgart" 0 "agpgart"
/etc/path_to_inst.old:59:"/pci at 0,0/pci8086,100 at 0" 0 "agptarget"



And: If I recall correctly, with the agp stuff (again, the term "agp" is totally misleading, it is always necessary!) you won't even be lucky if your external pciid bindings for add_drv are correct. It will still complain during inititialization until the correct pciids are also compiled in.

Focus for this example especially on:


/etc/driver_aliases:1105:agptarget "pci8086,100"
/etc/driver_aliases:1106:agptarget "pci8086,104"
/etc/driver_aliases:1107:agptarget "pci8086,108"


Now, here the explanation:


In i915 as pointed out by yourself you have this in contrast:

https://hg.openindiana.org/upstream/oracle/x-cons/x-s12-clone/file/5dc3c751c9c5/pkg/manifests/driver-graphics-drm.p5m

alias=pci8086,102 
alias=pci8086,106 


or, next example:



/etc/driver_aliases:1108:agptarget "pci8086,150"
/etc/driver_aliases:1109:agptarget "pci8086,154"
/etc/driver_aliases:1110:agptarget "pci8086,158"



then again in 915 you have:
alias=pci8086,152 \
alias=pci8086,156 \
alias=pci8086,15a \



Notice something???
If I understand it correctly, you _got_ that port from Sun China during PSARC 2014/148 Move DRM drivers to X11
So it is no problem if you enver noticed this correlation.


But don't deal with me like with some fool. And once again: I didn't change your license string.
The updated year (from 2013 to 2015) happened, because on November 30th Niveditha has committed this change to the gate, while I was still using a local checkout from before.
When I created the diffs however, I took a fresh checkout to create the diff against.
So you criticism for messing with your copyright should be forwarded right back to Oracle.













-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20151212/5e825a37/attachment-0005.html>


More information about the oi-dev mailing list