[oi-dev] Automated oi-userland reviews: feedback

[Adam Števko]

Hello,

I have been playing with Danger today and I was able to put up together a system, which will check incoming pull requests for style fixes / notify people about things that are usually forgotten e.g. bumping COMPONENT_REVISION, claiming copyrights, WS_TOP -> WS_MAKE_RULES, adding REQUIRED_PACKAGES and etc.

Workflow (how it work once merged):
  - open a PR against openindiana/oi-userland
  - Travis (3rd party CI service) will be notified and will spawn Ubuntu container, which will run Danger and do the magic
  - results will be posted in a form of Github reviews to the PR and contributor can check it. If problems arise, he can fix it until the build passes the check

Example: https://github.com/xen0l/oi-userland/pull/3 <https://github.com/xen0l/oi-userland/pull/3>

I would be interested in feedback on usability / text formatting (e.g. file paths can be made a link to file directly) / additional check types. I am also investigating option of inline commenting.

Cheers,
Adam



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20170404/ea1b27f4/attachment-0004.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20170404/ea1b27f4/attachment-0004.bin>