[oi-dev] exiv2 broken?

[Andreas Wacknitz]

Am 12.05.17 um 08:06 schrieb Carsten Grzemba:
>
>
> On 11.05.17 21:20, *Andreas Wacknitz * <A.Wacknitz at gmx.de> wrote:
>>
>> Sorry, I haven't been able to help here. I am quite busy with private 
>> things at the moment.
>>
>> Regards,
>> Andreas
>>
>> Am 11.05.17 um 13:42 schrieb Carsten Grzemba:
>>>
>>>
>>> On 10.05.17 07:21, *Carsten Grzemba * <grzemba at contac-dt.de> wrote:
>>>>
>>>>
>>>> On 09.05.17 23:16, *Adam Števko * <adam.stevko at gmail.com> wrote:
>>>>> Hey,
>>>>>
>>>>> yes and possibly submit a fix, please.
>>>>>
>>>>> Thanks,
>>>>> Adam
>>>>>
>>>>> > On May 9, 2017, at 7:56 PM, Andreas Wacknitz <A.Wacknitz at gmx.de> 
>>>>> wrote:
>>>>> >
>>>>> > Ok, after reading the sources a little bit more I found out that 
>>>>> the missing include file should be generated.
>>>>> > So it's a problem in our build. Shall I create a ticket?
>>>>> >
>>>>> > Andreas
>>>>> >
>>>>> >
>>>>> > Am 09.05.17 um 19:15 schrieb Andreas Wacknitz:
>>>>> >> Hi,
>>>>> >>
>>>>> >> when I try to build geeqie or gthumb packages with exiv2 
>>>>> installed I get compiler errors like this:
>>>>> >>
>>>>> >> In file included from /usr/include/exiv2/types.hpp:35:0,
>>>>> >>                 from /usr/include/exiv2/image.hpp:39,
>>>>> >>                 from 
>>>>> /oibuild/oi-userland/components/image/geeqie/geeqie-1.3/src/exiv2.cc:25:
>>>>> >> /usr/include/exiv2/config.h:10:23: fatal error: exv_conf.h: No 
>>>>> such file or directory
>>>>> >> # include "exv_conf.h"
>>>>> >>                       ^
>>>>> >> compilation terminated.
>>>>> >>
>>>>> >> It seems as if the exiv2 package is missing this important 
>>>>> configuration file. As far as I can tell this not
>>>>> >> only a problem with our exiv2 package but also with the 
>>>>> original sources as well. For me it looks as if
>>>>> >> this library has only been used and tested with Visual Studio. 
>>>>> What do you think?
>>>>> >>
>>>>> >> Regards
>>>>> >> Andreas
>>>>
>>>> I didn't include this header file because it is a result of 
>>>> configure step, so I thought it will also regenerated if you use 
>>>> the lib for other OSS projects.
>>>> I hope I will have the time to look at this week.
>>>>
>>>> A ticket with your steps on gegl are wellcome.
>>>>
>>>> Carsten
>>> I created a PR which includes exv_conf.h in package
>>
> It should be fixed, please try build of geeqie again.
>
> Carsten
Yes, it now builds fine. I expect that gnome-commander and gthumb will 
do, too.
BTW: What about publishing these packages with exiv2 enabled?

Andreas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20170512/cf820d75/attachment-0005.html>