[oi-dev] atge driver issue

[Gary Mills]

On Fri, Jul 02, 2021 at 03:47:25PM +0200, Carsten Grzemba wrote:
> 
>    It seems the fix is simple:

I'm pleased to hear that.

>    --- a/usr/src/uts/common/io/atge/atge_main.c
>    +++ b/usr/src/uts/common/io/atge/atge_main.c
>    @@ -256,7 +256,7 @@ static      mii_ops_t atge_l1c_mii_ops = {
>    Â Â Â Â Â Â Â  atge_l1c_mii_read,
>    Â Â Â Â Â Â Â  atge_l1c_mii_write,
>    Â Â Â Â Â Â Â  atge_mii_notify,
>    -Â Â Â Â Â Â  NULL
>    +Â Â Â Â Â Â  atge_l1c_mii_reset
>    Â };
>    Â
>    the function atge_l1c_mii_reset exist already but is not registeredÂ
>    in the mii_ops table.

I haven't looked at the source for a long time.  I don't know why
that function is missing from that table.  Is it called from another
place, or is it just floating?  You might need the NULL line if the
table is ever searched.

>    With this the "atge0: L1C chip detected a fatal error, interrupt
>    status: 2200" did not occur again on cable disconnect.
> 
>    The interface is working if the cable is connected again.

Since you found the bug and the solution, you are welcome to file
an illumos bug report and PR for the driver.


-- 
-Gary Mills-		-refurb-		-Winnipeg, Manitoba, Canada-