[oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES

[Andreas Wacknitz]

Am 27.03.21 um 16:59 schrieb stes at PANDORA.BE:
> The shared-macros.mk in oi-userland/make-rules could do:
>
> shared-macros.mk:REQUIRED_PACKAGES += shell/ksh93
>
> where it is currently doing
>
> shared-macros.mk:REQUIRED_PACKAGES += SUNWcs
>
> Currently on an older OpenIndiana system I have:
>
> $ pkg search /usr/bin/sh
> INDEX      ACTION VALUE      PACKAGE
> path       link   usr/bin/sh pkg:/SUNWcs at 0.5.11-2020.0.1.20038
> path       link   usr/bin/sh pkg:/shell/ksh93 at 93.21.1.20120801-2020.0.1.20424
>
> $ ls -l /bin/sh
> lrwxrwxrwx   1 root     root           9 Sep 16  2020 /bin/sh -> i86/ksh93
>
> So if a component provides a script with /bin/sh it requires either SUNWcs or shell/ksh93.
>
> But the oi-userland/make-rules/shared-macros.mk modification could perhaps deal with most cases.
You are right. But probobly I wasn't explicit enough: The main question
is how to deal with
the situation. Changing so many packages would take some time and occupy
the build server for a while.
So maybe it would be better to update the build server to the latest
osnet-incorporation now
and change package dependencies when needed, eg. when we touch a package
anyways.
But that would also render some (all?) actual PR's buggy and they have
to be redone.

>
> ----- Op 27 mar 2021 om 16:13 schreef gary mills gary_mills at fastmail.fm:
>
>> On Sat, Mar 27, 2021 at 09:41:12AM +0100, Andreas Wacknitz wrote:
>>
>>> illumos-gate has recently merged the following changes
>>>      2755 split ksh93 from core package
>>>      13460 ksh93 tests should be moved out of usr/demo
>>>      518 ksh documentation should be moved out of SUNWcsr
>>>
>>> This has impacts on our REQUIRED_PACKAGES settings for many packages.
>>> Most, if not all occurrences of
>>>      REQUIRED_PACKAGES += SUNWcs
>>> need to be replaced by
>>>      REQUIRED_PACKAGES += shell/ksh93
>> Is that really true?  I would have thought that all products would
>> require SUNWcs, but only ones that included ksh scripts would require
>> shell/ksh93 .  The problem is that you can't tell which to change from
>> the REQUIRED_PACKAGES make variable.  Is there not a default for that
>> variable?  Maybe adding both packages would be a quick fix, although
>> it's incorrect in many cases.  Is there a way to determine which
>> products actually require the shell/ksh93 package?
>>
>>
>> --
>> -Gary Mills-		-refurb-		-Winnipeg, Manitoba, Canada-
>>
>> _______________________________________________
>> oi-dev mailing list
>> oi-dev at openindiana.org
>> https://openindiana.org/mailman/listinfo/oi-dev
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> https://openindiana.org/mailman/listinfo/oi-dev