[oi-dev] rrdtool update questions

[Friedrich Kink]

Hi Andreas,

thank you very much, WORKS!! Your solution is not intrusive therefor I 
prefer.

Will check it in tomorrow once I figured out how to deal with failed tests.

kind regards,

   Fritz

Am 11.01.2022 um 21:16 schrieb Andreas Wacknitz:
> Am 11.01.22 um 20:51 schrieb Klaus Ziegler:
>> Hi Fritz,
>>
>> this publish error can be fixed in:
>> .../oi-userland/tools/python/pkglint:
>>
>> @@ -333,8 +333,6 @@
>>
>>                  if bits == 32 and path64:
>>                          result = _("32-bit object '%s' in 64-bit path")
>> -                elif bits == 64 and not path64:
>> -                        result = _("64-bit object '%s' in 32-bit path")
>>                  return result
>>
>>          def file_action(self, action, manifest, engine, 
>> pkglint_id="001"):
>>
>> @Andreas,
>> perhaps we should make this the default, as we anyway move forward
>> to migrate more and more apps/libs/tool  to be only 64bit, what di 
>> you think?
> There are other things possible: Either add a "pkg.linted=true" column 
> if only a single action is affected or add a transform rule in the 
> manifest, eg.
> <transform path=usr/lib/python3.7/site-packages/.*\.so -> default 
> pkg.linted.userland.action001.2 true>
>
> This way you can deliberately turn the error off.
>
>
>>
>> Many Regards
>> Klaus
>>
>>
>>
>> On 1/11/22 18:10, Friedrich Kink via oi-dev wrote:
>>>
>>> Hi all,
>>>
>>> based on Andreas' comment I rebuild rrdtool exclusively 2for 64-bit. 
>>> This added also support for all bindings lua, tcl, perl, ruby (v2.6) 
>>> and pyhton (v3.7). Though python created some headache. It build 
>>> needs an ugly tweak of the configure script to find the right header 
>>> files. The issue is cause by /usr/include/pyhton3.7*m. *Both version 
>>> python3.7 and pyhton3.7m reports back PYTHON_VERSION 3.7. Based on 
>>> this return the PYTHON_INCLUDES is always created as 
>>> /usr/include/pyhton3.7 which does not exist. Is this intentional 
>>> (the real path is /usr/include/pyhton3.7m, just a warmup question 
>>> ;-). But the real problem I have with this python binding is this 
>>> error when publishing:
>>>
>>> /usr/bin/python3.5 /usr/bin/pkglint  \
>>>                 -f /usr/share/src/myoi-userland/tools/pkglintrc 
>>> /usr/src/myoi-userland/components/image/rrdtool/build/manifest-i386-rrdtool.depend.res
>>> Lint engine setup...
>>> Starting lint run...
>>> ERROR userland.action001.2        64-bit object 
>>> 'usr/lib/python3.7/site-packages/rrdtool.cpython-37m.so' in 32-bit path
>>> WARNING pkglint.action005.1       obsolete dependency check skipped: 
>>> unable to find dependency 
>>> pkg:/image/library/libpng16 at 1.6.37-2020.0.1.0 for 
>>> pkg:/image/rrdtool at 1.7.2,5.11-2022.0.0.0
>>>
>>> Is there a way to overcome this problem or should i just remove the 
>>> python3.7 binding (basically all pathon3.x versions)? BTW phyton2.7 
>>> would work without problem including publishing but I didn't want to 
>>> create a dependency to this soon to be deprecated/removed version.
>>>
>>> kind regards,
>>>
>>>   Fritz
>>>
>>> PS: What about failing tests? Are they just to be reported or should 
>>> I try to fix them?
>>>
> It would be good to fix failing tests. Alas it's not always possible 
> and sometimes it would take more time than reasonable.
> So you should decide whether it's worth the efforts to fix a test. In 
> my opinion it depends on the importance and severity of the failure.
> In this case it's only marginally as we probably don't have many 
> rrdtool users with japanese locale settings.
>
> Regards,
> Andreas
>
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> https://openindiana.org/mailman/listinfo/oi-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20220111/9125c02d/attachment-0001.html>