[oi-dev] Valgrind

[Paul Floyd]

On 15-02-25 11:33, Till Wegmüller wrote:
> Hey Paul
> 
> Looking forward to your contribution. Here is the documentation for 
> Packaging your Valgrind port. https://docs.openindiana.org/dev/userland/ 
> #a-component-usually-consists-of-several-files If you need a Vagrant box 
> I Maintain those :)

Hi

Part of the reason that I'm trying to fix things for Solaris and Illumos 
Valgrind is that I'm in the process of retiring my old Solaris 11.3 
workstation. Hopefully I'll get OpenIndiana running on my new PC. 
That'll be another subject, probably for -discuss. For the moment I'm 
using VirtualBox, which is god enough.

I've been maintaining the FreeBSD port of Valgrind for a few years now. 
FreeBSD has 2 ports. devel/valgrind which uses official releases (which 
are toward the end of April and October each year) and very occasionally 
gets a patch. devel/valgrind-devel uses sourceware (the Valgrind host) 
snapshots and gets updated when there's a significant new feature or bug 
fix. That also saves me the bother of having to maintain a patchset.

Looking at
https://github.com/OpenIndiana/oi-userland/tree/oi/hipster/components/developer/valgrind

in the test directory there's a test results status
== 835 tests, 62 stderr failures, 14 stdout failures, 0 stderrB 
failures, 0 stdoutB failures, 6 post failures ==

I do quite a bit better than that with a build from git HEAD:

== 900 tests, 47 stderr failures, 1 stdout failure, 1 stderrB failure, 5 
stdoutB failures, 2 post failures ==


In the patches directory there are 8 patches.
01 changes the include path of scalar.h. I don't see any use in doing 
that as the build compiles with -I../solaris

02 adds a 'scripts' directory to the list to ignore when checking 
headers. I'm not sure what this is for as there isn't a scripts 
directory at the top level. Maybe for OI.

03 forces the vg_regtest script to always return 0, maybe an OI thing.

04 patches the execve test. Works OK for me without the patch.

05 this got merged upstream a bit over a year ago

06 also merged upstream

07 I'll look at this and merge if I can

08 turns off gdbserver tests. I get a few fails but ho hangs so it's 
probably safe to no longer use this patch now.

A+
Paul