[OpenIndiana-discuss] libvisual

[Tim Mooney]

In regard to: [OpenIndiana-discuss] libvisual, Gabriele Bulfon said (at...:

> Hi, I'm trying to rebuild libvisual from sources, a library that OI already has in its repo.
> I'm finding a lot of trouble building it, because Solaris seems not to be considered, while

Gabriele-

I'm not using OI yet, but I have built libvisual 0.4.0 from sources on
Solaris 10u8 using Studio 12.2.  I have two patches against stock
libvisual:

#
# lv_common.h doesn't include lvconfig.h, but it likely should.
#
%patch -p 1 -P 0

#
# lv_thread.c uses return in a couple void functions, fix.
#
%patch -p 1 -P 1


I don't know if the list allows attachments, so I'm including the two
patches inline.  Even if they don't come through nicely, you should
be able to pick out what I did.  If you ask me off list, I can send them
directly too.

PS: Since I plan on switching to some flavor of open Solaris for my new
desktop workstation, I was very pleased to see the announcement about
the Sonicle desktop distribution.  I have lots of experience building
software on Solaris for the desktop, so if I can help with patches etc.,
I would be happy to.

Tim
-- 
Tim Mooney                                             Tim.Mooney at ndsu.edu
Enterprise Computing & Infrastructure                  701-231-1076 (Voice)
Room 242-J6, IACC Building                             701-231-8541 (Fax)
North Dakota State University, Fargo, ND 58105-5164


diff -ur libvisual-0.4.0.orig/libvisual/lv_common.h libvisual-0.4.0/libvisual/lv_common.h
--- libvisual-0.4.0.orig/libvisual/lv_common.h	2006-01-22 07:23:37.000000000 -0600
+++ libvisual-0.4.0/libvisual/lv_common.h	2008-05-18 12:36:19.054775000 -0500
@@ -24,6 +24,8 @@
  #ifndef _LV_COMMON_H
  #define _LV_COMMON_H

+#include <libvisual/lvconfig.h>
+
  #include <libvisual/lv_defines.h>

  #include <libvisual/lv_mem.h>
--- libvisual-0.4.0.orig/libvisual/lv_types.h	2006-02-13 14:54:08.000000000 -0600
+++ libvisual-0.4.0/libvisual/lv_types.h	2008-05-18 13:02:00.373047000 -0500
@@ -38,7 +38,7 @@

  #define VISUAL_TABLESIZE(table)			(sizeof (table) / sizeof (table[0]))

-#if !defined(VISUAL_OS_WIN32)
+#if !defined(VISUAL_OS_WIN32) && !defined(VISUAL_OS_SOLARIS)
  #ifndef uint8_t
  #define uint8_t		u_int8_t
  #endif










--- libvisual-0.4.0.orig/libvisual/lv_thread.c	2006-02-13 14:54:08.000000000 -0600
+++ libvisual-0.4.0/libvisual/lv_thread.c	2008-05-18 12:58:03.081612000 -0500
@@ -312,7 +312,7 @@
  	visual_log_return_if_fail (visual_thread_is_supported () != FALSE);
  	visual_log_return_if_fail (visual_thread_is_enabled () != FALSE);

-	return __lv_thread_funcs.thread_exit (retval);
+	__lv_thread_funcs.thread_exit (retval);
  }

  /**
@@ -324,7 +324,7 @@
  	visual_log_return_if_fail (visual_thread_is_supported () != FALSE);
  	visual_log_return_if_fail (visual_thread_is_enabled () != FALSE);

-	return __lv_thread_funcs.thread_yield ();
+	__lv_thread_funcs.thread_yield ();
  }

  /**