[oi-dev] oi-build review process

[Guido Berhoerster]

* Gordon Ross <gordon.w.ross at gmail.com> [2011-08-06 17:21]:
> On Sat, Aug 6, 2011 at 5:00 AM, Guido Berhoerster <gber at openindiana.org> wrote:
> > Hello Alasdair,
> [...]
> > I suppose you mean that the contributor hg exports all changesets
> > and the committer then uses "hg import --no-commit"? If so, then
> > yes, that would do it. In that case we use something like
> > ----8<----
> > <bug no> bug description
> > Author: Name <email>
> > Reviewed by: Name <email>
> > Reviewed by: Name <email>
> > [...]
> > ---->8----
> > as the format for commit message?
> 
> FYI, we use "hg commit -u $original_author" in illumos, which puts the
> original author's email in the change set author.  If you do that, then an
> "Author: ..." field would be redundant.

Right, that would be a possibility, however we'd probably need to
introduce a Committed by: or Sponsored by: field since hg doesn't
distinguish between author/committer.

> Otherwise, the above suggestion looks like what we've been doing
> over in illumos.
> 
> BTW, the reason for: bugid description... and the subsequent lines
> (with no blank lines) is that with onnv-tools, the "hg-active" command
> will produce an output file that works with "webrev -w ..."
> Not sure if you care about that, but I find it handy.

Right, the idea is to follow the common and established
Sun/Oracle/Illumos format. While we currently we don't use
webrev, a standardized and machine-processable format is
useful anyway and we might make use of it in a future toolset.

-- 
Guido Berhoerster