[oi-dev] Addition of GeoIP to oi-build

Alasdair Lumsden alasdairrr at gmail.com
Tue Dec 20 01:30:35 UTC 2011

Hi Jeppe,

On 12/19/11 10:40 PM, Jeppe Toustrup wrote:

> Could somebody please look through this change set, and see if
> everything looks okay?
> https://bitbucket.org/Tenzer/oi-build/changeset/7ca13070e339

Great stuff - thanks for doing this!

A few comments:

1. Could you replace the OpenSolaris CDDL notice with the Illumos one

2. Was this taken from userland-gate or written by yourself? If taken 
from userland-gate, you can keep the Oracle copyright in the Makefile 
and .p5m, otherwise remove it. In either case, please do add your own 
copyright line.

3. Use a transform at the top to set etc/GeoIP.conf and GeoIP.dat 
preserve=true, via:

<transform file path=etc/GeoIP\.conf -> default preserve true>
<transform file path=usr/share/GeoIP/GeoIP\.dat -> default preserve true>

This will ensure that if someone edits the conf or replaces the GeoIP 
database that it won't be wiped out on a "pkg update"

Apart from that, it looks good! Thank you very much for contributing this.



More information about the oi-dev mailing list