[oi-dev] 1589 package up xcowsay

[Josef 'Jeff' Sipek]

On Mon, Oct 03, 2011 at 06:35:36PM +0100, Bayard G. Bell wrote:
> On Sat, 2011-10-01 at 20:29 -0400, Josef 'Jeff' Sipek wrote:
> > Any issues with merging this?
> > 
> > http://hg.31bits.net/oi/oi-build-xcowsay/rev/e11ec815dd5b
> > 
> > (https://www.illumos.org/issues/1589)
> 
> 1) I'm not familiar with this package, but why are things like CFLAGS
> being set in source patches to Makefile.am and Makefile.in rather than
> as options passed to configure, which would be more self-documenting?

The package did that for whatever reason.  The patch that's part of my
commit takes those out.

> 2) again going to the self-documenting question, why is the upstream URL
> provided directly in the manifest but not at all in the Makefile?

Just a bad habit on my part.  I'll fix this.

Jeff.

-- 
I'm somewhere between geek and normal.
		- Linus Torvalds