[oi-dev] build environment modifications

Alexander Pyhalov alp at rsu.ru
Mon Aug 5 17:50:50 UTC 2013


Hello, Adam.

Adam Števko писал 05.08.2013 19:50:

> https://github.com/xen0l/oi-userland/commit/6842d7ffb4ed409a276f9e06a8e5310ad7d5764f
> - Alasdair's issue (https://www.illumos.org/issues/2682), which brings
> in sane default for configuration environment. Many components already
> sets these in their Makefile and I don't see reasons, why we shouldn't
> make them default.
> I commented out CONFIGURE_OPTIONS as I found them redundant. From my
> understanding, configure will set these to environment variables, so
> CONFIGURE_ENV should be sufficient. If there are any objections I will
> restore CONFIGURE_OPTIONS.

I don't think that this is redundant. Are you sure in this?
It seems I've seen cases when CONFIGURE_ENV was no enough
(whaen configure in its own turn called configure).
I would dublicate all CONFIGURE_ENV (CC,LD,CFLAGS,etc...)  settings in 
CONFIGURE_OPTIONS.
Otherwise changes look reasonable.
---
System Administrator of Southern Federal University Computer Center






More information about the oi-dev mailing list