[oi-dev] build environment modifications
Adam Števko
adam.stevko at gmail.com
Mon Aug 5 18:19:33 UTC 2013
I will add these shortly.
On Aug 5, 2013, at 7:50 PM, Alexander Pyhalov <alp at rsu.ru> wrote:
> Hello, Adam.
>
> Adam Števko писал 05.08.2013 19:50:
>
>> https://github.com/xen0l/oi-userland/commit/6842d7ffb4ed409a276f9e06a8e5310ad7d5764f
>> - Alasdair's issue (https://www.illumos.org/issues/2682), which brings
>> in sane default for configuration environment. Many components already
>> sets these in their Makefile and I don't see reasons, why we shouldn't
>> make them default.
>> I commented out CONFIGURE_OPTIONS as I found them redundant. From my
>> understanding, configure will set these to environment variables, so
>> CONFIGURE_ENV should be sufficient. If there are any objections I will
>> restore CONFIGURE_OPTIONS.
>
> I don't think that this is redundant. Are you sure in this?
> It seems I've seen cases when CONFIGURE_ENV was no enough
> (whaen configure in its own turn called configure).
> I would dublicate all CONFIGURE_ENV (CC,LD,CFLAGS,etc...) settings in CONFIGURE_OPTIONS.
> Otherwise changes look reasonable.
> ---
> System Administrator of Southern Federal University Computer Center
>
>
>
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20130805/22e57db3/attachment-0005.bin>
More information about the oi-dev
mailing list