[oi-dev] Small fix to components/illumos/illumos-gate/Makefile

Alexander Pyhalov alp at rsu.ru
Sat Oct 19 21:43:34 UTC 2013


No, it seems I have to sleep a bit more.
This lead to error only when second argument is empty, which can happen 
only on update after clean...
Sorry for the noice.

---
System Administrator of Southern Federal University Computer Center

Alexander Pyhalov писал 20.10.2013 01:32:
> Hello.
> 
> It seems that I've found small lucky error in illumos-gate component 
> Makefile.
> The fix is trivial -
> https://github.com/pyhalov/oi-userland/compare/illumos-gate?expand=1
> 
> Firstly I think this error appears only when .downloaded doesn't exist.
> But it seems to appear every time.
> In result we have  something like the following shell code:
> 
> [ 0a74ce92c805db83288a376e512ff3172ae3aad0 ==
> b092dd82d7aceeaa520fe9404a377e6efeb923fe ] || git log -1 --format=%H >
> .downloaded
> 
> or, even better
> 
> [ 0a74ce92c805db83288a376e512ff3172ae3aad0 ==  ] || git log -1
> --format=%H > .downloaded
> 
> The test fails with error and git log is executed.
> The intention is to update .downloaded file only if there were changes
> in illumos gate and so trigger illumos-gate rebuild.
> But in result rebuild is triggered every time when Jenkins job is 
> executed.
> 
> Why do I call this error lucky? Because it allows us to catch userland
> changes which break illumos build as soon as they happen :)
> 
> So I'd suggest to fix script and possibly to change Jenkins logic - so
> that illumos gate is rebuild on every change in illumos-gate or
> oi-userland repositories.
> What do you think?




More information about the oi-dev mailing list