[oi-dev] Asking for opinions

[David CARLIER]

Thanks for the info I just sent the web rev to the mailing list we ll see.
Regards.

On 8 May 2017 at 18:04, Aurélien Larcher <aurelien.larcher at gmail.com> wrote:

> Hi,
>
> Since your fix is related to illumos-gate I suggest to read
>
> https://wiki.illumos.org/display/illumos/How+To+Contribute
>> http://illumos.org/books/dev/
>>
>> to get more info about contributing to illumos.
>>
>
> I submitted my first request to integrate very recently and I can confirm
> that the steps described on the Wiki cover pretty much everything.
>
> To summarize the steps:
>
> 1) Publish a webrev with your changes using the webrev or the review board
> [1].
>
> 2) Ask for review by sending an email to the illumos developer mailing
> list [2], describing the change and how it was tested.
>
> 3) When you have at least two reviewers validating the change, send an
> email to the advocates mailing list [3]
>
> The email to be sent for RTI has no strict format, so I looked at previous
> message in the archives, like the following:
>
> https://illumos.topicbox.com/groups/advocates/discussions/
> Tdf240fa5ca857b39
>
> as described in "5. Submitting A Patch": `git whatchanged`, `git pbchk`,
> and the mail_msg file should be provided.
>
> The only thing that could be clarified is that the review board seems the
> preferred way to ask for review but its usage is not described much.
>
> Nice that you fixed the memory leak, I noticed it when I tested the
> Valgrind update to 3.12 but then forgot about it :S Thanks!
> Kind regards
>
> Aurelien
>
>
> [1] https://www.illumos.org/rb
> [2] https://www.listbox.com/subscribe/?listname=developer@lists.
> illumos.org
> [3] advocates at lists.illumos.org
>
>
>
>
>
>
>>
>>
>> Thanks.
>>
>> --
>> +-------------------------------------------+
>> | Marcel Telka   e-mail:   marcel at telka.sk  |
>> |                homepage: http://telka.sk/ |
>> |                jabber:   marcel at jabber.sk |
>> +-------------------------------------------+
>>
>>
>> _______________________________________________
>> oi-dev mailing list
>> oi-dev at openindiana.org
>> https://openindiana.org/mailman/listinfo/oi-dev
>
>
>
>
> --
> ---
> Praise the Caffeine embeddings
>
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> https://openindiana.org/mailman/listinfo/oi-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20170508/dd8b37ff/attachment-0005.html>