[oi-dev] Whitespace in Makefiles in oi-userland keep causing Problems

[Aurélien Larcher]

On Fri, Sep 28, 2018 at 1:48 PM Till Wegmüller <toasterson at gmail.com> wrote:

> I managed to get it Working by hardcoding every Value with a Whitespace
> inside it in the Package manifest.
>
> Looks like the problem seems to be the way gmake passes Variables to
> pkgmogrify. It usualy does so by specifying -D $VARIABLE on the command
> line. That seems not to be working consistently.
>
> So lesson from that seems to be that we need to hardcode values with
> whitespace into the manifest.
>
> Thanks for the pointers.
>

I am not sure this is the case, there are other instances of values with
whitespaces.
The way values are quoted should be influencial depending on how the recipe
passes them to pkgmogrify.
There is a similar problem with non-escaping dots in PKG_MACROS.



>
> Greetings
> Till
>
> On 09/28/18 12:23 PM, Joerg Schilling wrote:
> > Till Wegmüller <toasterson at gmail.com> wrote:
> >
> >> A Makefile like so:
> >>
> >> <snip>
> >> COMPONENT_NAME=salt
> >> COMPONENT_VERSION=2018.3.2
> >> COMPONENT_SUMMARY='Portable, distributed, remote execution and
> >> configuration management system'
> >> COMPONENT_PROJECT_URL=http://saltstack.com
> >> COMPONENT_FMRI=system/management/$(COMPONENT_NAME)
> >> COMPONENT_CLASSIFICATION='System/Administration and Configuration'
> >> <snip>
> >>
> >> Something like COMPONENT_CLASSIFICATION would break pkgmogrify with:
> >> pkgmogrify: File
> >>
> /export/home/toast/workspace/openindiana/userland/components/python/salt/build/manifest-i386-salt-27.p5m
> >> line 18: Malformed action at position: 90: whitespace in key:
> >>     set name=info.classification
> >> value=org.opensolaris.category.2008:System/Administration and
> Configuration
> >
> > It would help if you could investigate and report on what happenes that
> causes
> > your problem and whether you are unhappy with "make" or with the called
> > program...
> >
> > BTW: do you use "gmake" or make?
> > gmake is known to have a buggy white space handling.
> >
> > Jörg
> >
>
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> https://openindiana.org/mailman/listinfo/oi-dev



-- 
---
Praise the Caffeine embeddings
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20180928/3dca31e0/attachment-0005.html>