[oi-dev] rrdtool update

[stes@PANDORA.BE]

I've just created two pull requests for two different components : opensmalltalk stack-spur and opensmalltalk cog-spur.

I update those 2 opensmalltalk components by 2 different PR (pull requests).

My understanding is that although that one pull requests for two components is perhaps technically possible at the git revision control level, there is a disadvantage at the "jenkins" level for doing so, so although I do not quite know why this is or what the jenkins problem is, but you should create 2 different PR (pull requests) if you update 2 different components ...

As to how to correct now the problem, I'm not sure what the best way is.

The best solution is not to make this mistake ...

But of course it's good to try out an update of some components to see what you should be careful about and like this after a while you'll know how to avoid these issues.

David Stes

----- Op 7 jan 2022 om 21:57 schreef oi-dev oi-dev at openindiana.org:

> Hi all,
> 
> I updated rrdtool to latest version 1.7.2 incl. 32-bit and 64-bit perl/lua
> bindings. I learnt a lot about the build environment. As a consequence to
> successfully publish both 32bit and 64bit binaries and perl/lua bindings
> respectively I had to create four *.p5m files which ended up in six packages.
> If you have better ideas please share (I still have to learn a lot ;-)).
> 
> 
> But it seems that I've committed ( [
> https://github.com/OpenIndiana/oi-userland/pull/7525/commits/0a62194cb51c08012031700d7ea6f592593568ac
> | 0a62194 ] ) all related changes to my previous github branch (where I added
> the tk-perl module). I guess this is wrong :-(. This is reflected in PR#7525.
> What is the best method to correct?
> 
> kind regards and thank you for answers in advance,
> 
> Fritz
> 
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> https://openindiana.org/mailman/listinfo/oi-dev