[oi-dev] Purpose of PACKAGE_NAMES

[Aurélien Larcher]

On Fri, Sep 29, 2023 at 10:15 AM Marcel Telka <marcel at telka.sk> wrote:

> Hi,
>
> I noticed there are PACKAGE_NAMES macros set for few components in the
> oi-userland git repo.  Namely here:
>
> components/meta-packages/history/Makefile
> components/openindiana/gfx-drm/Makefile
> components/openindiana/pkg/Makefile
> components/openindiana/slim_source/Makefile
>
> They were added in October 2018 by following commits:
>
> c7b5e23fc94
> 2e3897664af
> ac1196a7cb0
> a4bb6ce259f
>
> I'm curious what is the purpose of these macros.  As far as I know there
> is no known consumer for them.  They looks like some attempt to list
> packages generated by a component before we had support for pkg5 files
> (introduced in 2020).
>
> If PACKAGE_NAMES are unused then I plan to simply remove them once I
> touch those Makefiles.
>

If I remember correctily they were introduced to produce package names used
in dependency resolution in the external python scripts, for components
that generate packages internally and then copy them rather than the usual
procedure.
The goal was to trigger rebuild of dependencies based on this information
and avoid publication of broken repositories e.g. when ABI is broken and
the update is split in several PRs due to our flawed CI.
Without these definitions print-package-names would produce an incomplete
list of packages provided by the component and the graph will have dangling
dependencies.
However I am not sure if the bass/component.py script still relies on these
definitions (there is also a build-plan branch that attempts to automate
rebuild of dependencies).



>
>
> Thank you.
>
> --
> +-------------------------------------------+
> | Marcel Telka   e-mail:   marcel at telka.sk  |
> |                homepage: http://telka.sk/ |
> +-------------------------------------------+
>
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> https://openindiana.org/mailman/listinfo/oi-dev
>


-- 
---
Praise the Caffeine embeddings
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20230929/46ccbffb/attachment.html>