[oi-dev] 1638 add a clean urxvt build to oi-build

[Bayard Bell]

On Sat, Feb 11, 2012 at 2:50 PM, Josef 'Jeff' Sipek
<jeffpc at josefsipek.net>wrote:

> On Fri, Feb 10, 2012 at 07:53:09PM +0000, Bayard Bell wrote:
> > I know that jeffpc mentioned having a patch for issues with an earlier
> > version, but it wasn't attached to the issue. I don't know, either, if
> it's
> > still applicable to the recent version to which I've just upgraded. I
> trust
> > that will come out in the course of review.
> >
> > https://bitbucket.org/buffyg/oi-build/changeset/3b8c1e923e14
>
> utmp_update is broken (it doesn't do what POSIX says it should) and so it's
> really an illumos bug.  I talked with urxvt folks quite a bit about it, and
> IIRC, they were going to include a workaround.  Looking at the Changelog it
> looks like that didn't happen.
>
> The copyright is wrong unless you took this from Oracle.
>
> And three small nits...
>
> 1) Why the OSOL CDDL header instead of the Illumos CDDL header?
>

I cleaned up the copyright just after submitting. See previous response for
rest.


> 2) Why keep all those commented out lines in there?
>

Ditto.


> 3) What's the reasoning behind setting $PATH?
>

Copying and generally assuming that most stuff that stuff that builds with
gcc is happier preferring GNU tools to SVR4 ones.


>
> Jeff.
>
> P.S. FWIW, the correct way to fix utmp_update is to rip it out and write it
> from scratch.
>
> --
> If I have trouble installing Linux, something is wrong. Very wrong.
>                - Linus Torvalds
>
> _______________________________________________
> oi-dev mailing list
> oi-dev at openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openindiana.org/pipermail/oi-dev/attachments/20120212/8cb860cf/attachment-0005.html>